diff --git a/CMakeLists.txt b/CMakeLists.txt
index 0f8894a33cbe0c30491afeba501c603c4f748b09..6861a4bfb33b6ab1d34a08e7082981a3119165a8 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -7,7 +7,7 @@ project(OpenStructure CXX C)
set (CMAKE_EXPORT_COMPILE_COMMANDS 1)
set (OST_VERSION_MAJOR 1)
set (OST_VERSION_MINOR 4)
-set (OST_VERSION_PATCH 0)
+set (OST_VERSION_PATCH 1)
set (OST_VERSION_STRING ${OST_VERSION_MAJOR}.${OST_VERSION_MINOR}.${OST_VERSION_PATCH} )
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${PROJECT_SOURCE_DIR}/cmake_support)
include(OST)
diff --git a/modules/io/pymod/export_mmcif_io.cc b/modules/io/pymod/export_mmcif_io.cc
index f798ba8c9c23a804a2bb0e08a9707aca0f58c374..7c6a5b69750a362f01842ad13c52b555353b017a 100644
--- a/modules/io/pymod/export_mmcif_io.cc
+++ b/modules/io/pymod/export_mmcif_io.cc
@@ -168,7 +168,8 @@ void export_mmcif_io()
.add_property("details", make_function(&MMCifInfoStructRefSeqDif::GetDetails,
return_value_policy<copy_const_reference>()))
.add_property("seq_rnum", &MMCifInfoStructRefSeqDif::GetSeqRNum)
- .add_property("db_rnum", &MMCifInfoStructRefSeqDif::GetDBRNum)
+ .add_property("db_rnum", make_function(&MMCifInfoStructRefSeqDif::GetDBRNum,
+ return_value_policy<copy_const_reference>()))
;
typedef std::pair<int, int> IntPair;
diff --git a/modules/io/src/mol/mmcif_info.cc b/modules/io/src/mol/mmcif_info.cc
index e7f391894cab4e8ace515de79fa14f6e047fd683..e7d47078cc5ae4c9f3c4dabee23dd55c72dd12e1 100644
--- a/modules/io/src/mol/mmcif_info.cc
+++ b/modules/io/src/mol/mmcif_info.cc
@@ -168,7 +168,7 @@ MMCifInfoStructRef::GetAlignedSeq(const String& aid) const
}
MMCifInfoStructRefSeqDifPtr
-MMCifInfoStructRefSeq::AddDif(int seq_rnum, int db_rnum, const String& details)
+MMCifInfoStructRefSeq::AddDif(int seq_rnum, const String& db_rnum, const String& details)
{
MMCifInfoStructRefSeqDifPtr d(new MMCifInfoStructRefSeqDif(seq_rnum, db_rnum,
details));
diff --git a/modules/io/src/mol/mmcif_info.hh b/modules/io/src/mol/mmcif_info.hh
index 832bfdc7684e2b1a6557a842739950af501767df..8087e7e0718972ddc1343899af4d69696fda1f3e 100644
--- a/modules/io/src/mol/mmcif_info.hh
+++ b/modules/io/src/mol/mmcif_info.hh
@@ -827,8 +827,8 @@ public:
int GetSeqEnd() const { return seq_end_; }
int GetDBBegin() const { return db_begin_; }
int GetDBEnd() const { return db_end_; }
- MMCifInfoStructRefSeqDifPtr AddDif(int seq_num, int db_num,
- const String& details);
+ MMCifInfoStructRefSeqDifPtr AddDif(int seq_num, const String& db_rnum,
+ const String& details);
const std::vector<MMCifInfoStructRefSeqDifPtr>& GetDifs() const { return difs_; }
private:
String id_;
@@ -842,14 +842,14 @@ private:
class DLLEXPORT_OST_IO MMCifInfoStructRefSeqDif {
public:
- MMCifInfoStructRefSeqDif(int seq_rnum, int db_rnum, const String& details):
+ MMCifInfoStructRefSeqDif(int seq_rnum, const String& db_rnum, const String& details):
seq_rnum_(seq_rnum), db_rnum_(db_rnum), details_(details) {}
int GetSeqRNum() const { return seq_rnum_;}
- int GetDBRNum() const { return db_rnum_; }
+ const String& GetDBRNum() const { return db_rnum_; }
const String& GetDetails() const { return details_; }
private:
int seq_rnum_;
- int db_rnum_;
+ String db_rnum_;
String details_;
};
diff --git a/modules/io/src/mol/mmcif_reader.cc b/modules/io/src/mol/mmcif_reader.cc
index a59e545061d7e0f902414798ec0228f2f6da864a..3df667baf15fdcd215cef2c63cac5222c5b4232c 100644
--- a/modules/io/src/mol/mmcif_reader.cc
+++ b/modules/io/src/mol/mmcif_reader.cc
@@ -805,7 +805,7 @@ void MMCifReader::ParseCitation(const std::vector<StringRef>& columns)
}
}
if (indices_[YEAR] != -1) {
- if (columns[indices_[YEAR]][0]!='?') {
+ if (!is_undef(columns[indices_[YEAR]])) {
cit.SetYear(this->TryGetInt(columns[indices_[YEAR]], "citation.year"));
}
}
@@ -1542,33 +1542,30 @@ void MMCifReader::ParseStructRefSeq(const std::vector<StringRef>& columns)
void MMCifReader::ParseStructRefSeqDif(const std::vector<StringRef>& columns)
{
- String aln_id=columns[indices_[SRSD_ALIGN_ID]].str();
- std::pair<bool,int> db_rnum(true, -1);
- if (!is_undef(columns[indices_[SRSD_DB_RNUM]])) {
- db_rnum=this->TryGetInt(columns[indices_[SRSD_DB_RNUM]],
- "_struct_ref_seq_dif.pdbx_seq_db_seq_num",
- profile_.fault_tolerant);
-
- }
- std::pair<bool,int> seq_rnum(true, -1);
- if (!is_undef(columns[indices_[SRSD_SEQ_RNUM]])) {
- seq_rnum=this->TryGetInt(columns[indices_[SRSD_SEQ_RNUM]],
- "_struct_ref_seq_dif.seq_num",
- profile_.fault_tolerant);
-
- }
- if (!seq_rnum.first || !db_rnum.first) {
- return;
- }
+ String aln_id=columns[indices_[SRSD_ALIGN_ID]].str();
+ String db_rnum;
+ if (!is_undef(columns[indices_[SRSD_DB_RNUM]])) {
+ db_rnum=columns[indices_[SRSD_DB_RNUM]].str();
+ }
+ std::pair<bool,int> seq_rnum(true, -1);
+ if (!is_undef(columns[indices_[SRSD_SEQ_RNUM]])) {
+ seq_rnum=this->TryGetInt(columns[indices_[SRSD_SEQ_RNUM]],
+ "_struct_ref_seq_dif.seq_num",
+ profile_.fault_tolerant);
+
+ }
+ if (!seq_rnum.first) {
+ return;
+ }
String details;
if (indices_[SRSD_DETAILS]!=-1) {
details=columns[indices_[SRSD_DETAILS]].str();
- }
- bool found=false;
+ }
+ bool found=false;
for (MMCifInfoStructRefs::iterator i=struct_refs_.begin(),
e=struct_refs_.end(); i!=e; ++i) {
if (MMCifInfoStructRefSeqPtr s=(*i)->GetAlignedSeq(aln_id)) {
- s->AddDif(seq_rnum.second, db_rnum.second, details);
+ s->AddDif(seq_rnum.second, db_rnum, details);
found=true;
break;
}
diff --git a/modules/io/tests/test_mmcif_reader.cc b/modules/io/tests/test_mmcif_reader.cc
index 6f6866622c49c5a6e2f0259339e3c6b5508f4024..3a1906df9ea7c8f7ffc0dae6f79fcc9a54b7972e 100644
--- a/modules/io/tests/test_mmcif_reader.cc
+++ b/modules/io/tests/test_mmcif_reader.cc
@@ -584,16 +584,20 @@ BOOST_AUTO_TEST_CASE(mmcif_citation_tests)
tmmcif_h.SetCategory(StringRef("citation", 8));
tmmcif_h.Add(StringRef("id", 2));
+ tmmcif_h.Add(StringRef("year", 4));
tmmcif_h.Add(StringRef("book_title", 10));
tmmcif_h.Add(StringRef("journal_abbrev", 14));
tmmcif_p.OnBeginLoop(tmmcif_h);
columns.push_back(StringRef("Foo", 3));
+ columns.push_back(StringRef("1979", 4));
columns.push_back(StringRef("The Guide", 9));
columns.push_back(StringRef(".", 1));
BOOST_CHECK_NO_THROW(tmmcif_p.ParseCitation(columns));
+ BOOST_CHECK(tmmcif_p.GetInfo().GetCitations().back().GetYear() == 1979);
+
columns.pop_back();
columns.pop_back();
columns.push_back(StringRef(".", 1));