From ab2b0a172b15bec048ceddd797a86a9bf56450b9 Mon Sep 17 00:00:00 2001
From: Gabriel Studer <gabriel.studer@unibas.ch>
Date: Fri, 1 Feb 2019 21:41:13 +0100
Subject: [PATCH] not only promise to detach observer - DO IT
---
modules/gfx/src/render_options/render_options.cc | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/modules/gfx/src/render_options/render_options.cc b/modules/gfx/src/render_options/render_options.cc
index 5d8e7a72c..12690d820 100644
--- a/modules/gfx/src/render_options/render_options.cc
+++ b/modules/gfx/src/render_options/render_options.cc
@@ -41,11 +41,13 @@ bool RenderOptions::AddObserver(EntityP entity)
bool RenderOptions::RemoveObserver(EntityP entity)
{
- for (EntityWObservers::iterator
- i = observers_.begin(), e = observers_.end(); i != e; ++i) {
- if (i->lock() == entity)
+ for (EntityWObservers::iterator i = observers_.begin(), e = observers_.end();
+ i != e; ++i) {
+ if (i->lock() == entity) {
observers_.erase(i);
return true;
+ }
+
}
return false;
}
--
GitLab