From b19070257aba7262026a4c215895e7000f691dc0 Mon Sep 17 00:00:00 2001 From: Niko Ehrenfeuchter <nikolaus.ehrenfeuchter@unibas.ch> Date: Mon, 12 Feb 2018 22:26:19 +0100 Subject: [PATCH] Move Serialize / Deserialize next to constructor method. --- ATxCommon/Serializables/ServiceConfig.cs | 34 ++++++++++++------------ 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/ATxCommon/Serializables/ServiceConfig.cs b/ATxCommon/Serializables/ServiceConfig.cs index 7eb183f..10d90df 100644 --- a/ATxCommon/Serializables/ServiceConfig.cs +++ b/ATxCommon/Serializables/ServiceConfig.cs @@ -31,6 +31,23 @@ namespace ATxCommon.Serializables EnforceInheritedACLs = true; } + public static void Serialize(string file, ServiceConfig c) { + // the config is never meant to be written by us, therefore: + throw new SettingsPropertyIsReadOnlyException("The config file must not be written by the service!"); + } + + public static ServiceConfig Deserialize(string file) { + Log.Debug("Trying to read service configuration XML file: [{0}]", file); + var xs = new XmlSerializer(typeof(ServiceConfig)); + var reader = File.OpenText(file); + var config = (ServiceConfig) xs.Deserialize(reader); + reader.Close(); + ValidateConfiguration(config); + Log.Debug("Finished deserializing service configuration XML file."); + return config; + } + + #region required configuration parameters /// <summary> @@ -243,23 +260,6 @@ namespace ATxCommon.Serializables #endregion - public static void Serialize(string file, ServiceConfig c) { - // the config is never meant to be written by us, therefore: - throw new SettingsPropertyIsReadOnlyException("The config file must not be written by the service!"); - } - - public static ServiceConfig Deserialize(string file) { - Log.Debug("Trying to read service configuration XML file: [{0}]", file); - var xs = new XmlSerializer(typeof(ServiceConfig)); - var reader = File.OpenText(file); - var config = (ServiceConfig) xs.Deserialize(reader); - reader.Close(); - ValidateConfiguration(config); - Log.Debug("Finished deserializing service configuration XML file."); - return config; - } - - /// <summary> /// Validate the configuration, throwing exceptions on invalid parameters. /// </summary> -- GitLab