From b4f963b9217d9f34e67190c5c5b8f4ea3189c1d1 Mon Sep 17 00:00:00 2001
From: Niko Ehrenfeuchter <nikolaus.ehrenfeuchter@unibas.ch>
Date: Sun, 11 Mar 2018 15:28:47 +0100
Subject: [PATCH] Add ToDo for OnStop(), improve comment.
---
ATxService/AutoTx.cs | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/ATxService/AutoTx.cs b/ATxService/AutoTx.cs
index 4e57a56..14a2daf 100644
--- a/ATxService/AutoTx.cs
+++ b/ATxService/AutoTx.cs
@@ -412,11 +412,12 @@ namespace ATxService
Log.Warn("{0} service stop requested...", ServiceName);
if (_transferState != TxState.Stopped) {
_transferState = TxState.DoNothing;
- // Stop() is calling Process.Kill() (immediately forcing a termination of the
- // process, returning asynchronously), followed by Process.Dispose()
+ // RoboCommand.Stop() is calling Process.Kill() (immediately forcing a termination
+ // of the process, returning asynchronously), followed by Process.Dispose()
// (releasing all resources used by the component). Would be nice if RoboSharp
// implemented a method to check if the process has actually terminated, but
// this is probably something we have to do ourselves.
+ // TODO: this has probably improved with recent versions of RoboSharp, check it!
try {
_roboCommand.Stop();
}
--
GitLab