Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
O
openstructure
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Container registry
Model registry
Analyze
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
schwede
openstructure
Commits
372c75ef
Commit
372c75ef
authored
Nov 3, 2010
by
Tobias Schmidt
Browse files
Options
Downloads
Patches
Plain Diff
Revert "added version check for msms unit test, fixes BZDNG-176"
This reverts commit
bb59a0df
.
parent
0b6c56ec
No related branches found
No related tags found
No related merge requests found
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
modules/bindings/pymod/msms.py
+1
-16
1 addition, 16 deletions
modules/bindings/pymod/msms.py
modules/bindings/tests/test_msms.py
+0
-4
0 additions, 4 deletions
modules/bindings/tests/test_msms.py
with
1 addition
and
20 deletions
modules/bindings/pymod/msms.py
+
1
−
16
View file @
372c75ef
...
@@ -38,21 +38,6 @@ class MsmsProcessError(Exception):
...
@@ -38,21 +38,6 @@ class MsmsProcessError(Exception):
return
repr
(
self
.
returncode
)
return
repr
(
self
.
returncode
)
def
GetVersion
(
msms_exe
=
None
,
msms_env
=
None
):
msms_executable
=
_GetExecutable
(
msms_exe
,
msms_env
)
command
=
"
%s
"
%
(
msms_executable
)
proc
=
subprocess
.
Popen
(
command
,
shell
=
True
,
stdout
=
subprocess
.
PIPE
)
stdout_value
,
stderr_value
=
proc
.
communicate
()
version
=
""
for
l
in
stdout_value
.
splitlines
():
if
l
[
0
:
4
]
==
'
MSMS
'
:
version
=
l
.
split
(
'
'
)[
1
]
return
version
if
version
==
""
:
LogWarning
(
'
Could not parse MSMS version string
'
)
return
## \brief Method to check if MSMS executable is present
## \brief Method to check if MSMS executable is present
#
#
# \param msms_exe Explicit path to msms executable
# \param msms_exe Explicit path to msms executable
...
@@ -135,7 +120,7 @@ def _RunMSMS(command):
...
@@ -135,7 +120,7 @@ def _RunMSMS(command):
#check for successful completion of msms
#check for successful completion of msms
if
proc
.
returncode
!=
0
:
if
proc
.
returncode
!=
0
:
print
"
WARNING: msms error
\n
"
,
stdout_value
print
"
WARNING: msms error
\n
"
,
stdout_value
raise
MsmsProcessError
(
proc
.
returncode
,
command
)
raise
subprocess
.
MsmsProcessError
(
proc
.
returncode
,
command
)
return
stdout_value
return
stdout_value
...
...
...
...
This diff is collapsed.
Click to expand it.
modules/bindings/tests/test_msms.py
+
0
−
4
View file @
372c75ef
...
@@ -33,15 +33,11 @@ class TestMSMSBindings(unittest.TestCase):
...
@@ -33,15 +33,11 @@ class TestMSMSBindings(unittest.TestCase):
if
__name__
==
"
__main__
"
:
if
__name__
==
"
__main__
"
:
# test if msms package is available on system, otherwise ignore tests
# test if msms package is available on system, otherwise ignore tests
VERSION_REQUIRED
=
'
2.6.1
'
try
:
try
:
msms
.
_GetExecutable
(
msms_exe
=
None
,
msms_env
=
'
MSMSSERVER
'
)
msms
.
_GetExecutable
(
msms_exe
=
None
,
msms_env
=
'
MSMSSERVER
'
)
except
(
settings
.
FileNotFound
):
except
(
settings
.
FileNotFound
):
print
"
Could not find msms executable: ignoring unit tests
"
print
"
Could not find msms executable: ignoring unit tests
"
exit
(
0
)
exit
(
0
)
version
=
msms
.
GetVersion
(
msms_exe
=
None
,
msms_env
=
'
MSMSSERVER
'
)
if
version
!=
VERSION_REQUIRED
:
print
"
MSMS version (%s) does not match required version %s: ignoring unit tests
"
%
(
version
,
VERSION_REQUIRED
)
try
:
try
:
unittest
.
main
()
unittest
.
main
()
except
Exception
,
e
:
except
Exception
,
e
:
...
...
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
sign in
to comment