Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
O
openstructure
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Container registry
Model registry
Analyze
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
schwede
openstructure
Commits
eb943f7f
Unverified
Commit
eb943f7f
authored
Feb 1, 2024
by
Xavier Robin
Browse files
Options
Downloads
Patches
Plain Diff
cleanup: remove unnecessary check
CreateBU always returns a valid entity. We already check if it's empty separately.
parent
cca8d787
No related branches found
No related tags found
No related merge requests found
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
actions/ost-compare-ligand-structures
+0
-3
0 additions, 3 deletions
actions/ost-compare-ligand-structures
actions/ost-compare-structures
+0
-3
0 additions, 3 deletions
actions/ost-compare-structures
with
0 additions
and
6 deletions
actions/ost-compare-ligand-structures
+
0
−
3
View file @
eb943f7f
...
@@ -336,9 +336,6 @@ def _LoadStructure(structure_path, sformat, fault_tolerant, bu_id):
...
@@ -336,9 +336,6 @@ def _LoadStructure(structure_path, sformat, fault_tolerant, bu_id):
for biounit in cif_info.biounits:
for biounit in cif_info.biounits:
if biounit.id == bu_id:
if biounit.id == bu_id:
entity = ost.mol.alg.CreateBU(cif_entity, biounit)
entity = ost.mol.alg.CreateBU(cif_entity, biounit)
if not entity.IsValid():
raise IOError(
"Provided file does not contain valid entity.")
break
break
else:
else:
raise RuntimeError(f"No biounit found with ID '{bu_id}'.")
raise RuntimeError(f"No biounit found with ID '{bu_id}'.")
...
...
This diff is collapsed.
Click to expand it.
actions/ost-compare-structures
+
0
−
3
View file @
eb943f7f
...
@@ -582,9 +582,6 @@ def _LoadStructure(structure_path, sformat, fault_tolerant, bu_id):
...
@@ -582,9 +582,6 @@ def _LoadStructure(structure_path, sformat, fault_tolerant, bu_id):
for biounit in cif_info.biounits:
for biounit in cif_info.biounits:
if biounit.id == bu_id:
if biounit.id == bu_id:
entity = ost.mol.alg.CreateBU(cif_entity, biounit)
entity = ost.mol.alg.CreateBU(cif_entity, biounit)
if not entity.IsValid():
raise IOError(
"Provided file does not contain valid entity.")
break
break
else:
else:
raise RuntimeError(f"No biounit found with ID '{bu_id}'.")
raise RuntimeError(f"No biounit found with ID '{bu_id}'.")
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
sign in
to comment