-
- Downloads
mmcif writing: refactor
- Introduce code redundancy by removing star_base.hh again. It was a bad idea from the very beginning. The reader operated with ost::StringRef. A StringRef is purely pointer based which is fine when you have external data ownership. Thats the case for reading. For writing you want to build up a data structure that actually holds data. So you want to store actual strings. Thus the introduction of StarWriter objects. - Use shared_ptr instead of raw pointers - Change function names to better follow the OST conventions
Showing
- modules/io/src/mol/CMakeLists.txt 0 additions, 1 deletionmodules/io/src/mol/CMakeLists.txt
- modules/io/src/mol/mmcif_writer.cc 244 additions, 284 deletionsmodules/io/src/mol/mmcif_writer.cc
- modules/io/src/mol/mmcif_writer.hh 9 additions, 9 deletionsmodules/io/src/mol/mmcif_writer.hh
- modules/io/src/mol/star_base.hh 0 additions, 323 deletionsmodules/io/src/mol/star_base.hh
- modules/io/src/mol/star_parser.hh 61 additions, 1 deletionmodules/io/src/mol/star_parser.hh
- modules/io/src/mol/star_writer.hh 260 additions, 3 deletionsmodules/io/src/mol/star_writer.hh
Loading
Please register or sign in to comment