Skip to content
Snippets Groups Projects
Iris Mestres Pascual's avatar
Iris Mestres Pascual's avatar
deleted branch feat-output-prefix at zavolan_group / tools / ascii-alignment-pileup
Iris Mestres Pascual's avatar
closed issue #2 "feat: set output file name prefix" at zavolan_group / tools / ascii-alignment-pileup
Iris Mestres Pascual's avatar
  • ba08b20f · feat: add output prefix assignment
Iris Mestres Pascual's avatar
accepted merge request !10 "feat: add output prefix assignment" at zavolan_group / tools / ascii-alignment-pileup
Iris Mestres Pascual's avatar
opened merge request !10 "feat: add output prefix assignment" at zavolan_group / tools / ascii-alignment-pileup
Iris Mestres Pascual's avatar
closed merge request !10 "feat: add output prefix assignment" at zavolan_group / tools / ascii-alignment-pileup
Iris Mestres Pascual's avatar
pushed to branch feat-output-prefix at zavolan_group / tools / ascii-alignment-pileup
  • 63557718 · refactor: use NULL as default
Alex Kanitz's avatar
commented on merge request !10 "feat: add output prefix assignment" at zavolan_group / tools / ascii-alignment-pileup

I am approving already, because I don't think I need to rereview after the minor change I asked for. You can just merge, but make sure to squash me...

Alex Kanitz's avatar
approved merge request !10 "feat: add output prefix assignment" at zavolan_group / tools / ascii-alignment-pileup
Alex Kanitz's avatar
commented on merge request !10 "feat: add output prefix assignment" at zavolan_group / tools / ascii-alignment-pileup

I think it's better to use NULL as default, then check against NULL in the condition below. In that way, if a user wants to set the empty string as...

Iris Mestres Pascual's avatar
opened merge request !10 "feat: add output prefix assignment" at zavolan_group / tools / ascii-alignment-pileup
Iris Mestres Pascual's avatar
pushed to branch feat-output-prefix at zavolan_group / tools / ascii-alignment-pileup
Iris Mestres Pascual's avatar
pushed new branch feat-output-prefix at zavolan_group / tools / ascii-alignment-pileup
Iris Mestres Pascual's avatar
Iris Mestres Pascual's avatar
opened issue #2 "feat: set output file name prefix" at zavolan_group / tools / ascii-alignment-pileup
Alex Kanitz's avatar
opened issue #1 "Indicate how often a given read group occurs in genome" at zavolan_group / tools / ascii-alignment-pileup
Alex Kanitz's avatar
Alex Kanitz's avatar
deleted branch fix-ref-example at zavolan_group / tools / ascii-alignment-pileup
Alex Kanitz's avatar
  • a5c6a4a0 · fix: ref does not match pileups in example